forums.ps2dev.org

Posted: **Mon Sep 18, 2006 12:39 am**

When I open a binary file and try to read 0xFF with fgetc(), I get EOF (= 0xFFFFFFFF) instead.

The problem is in ps2sdk/ee/libc/src/stdio.c:

Code: Select all

int fgetc&#40;FILE *stream&#41;
&#123;
  char c;
  int ret;

  switch&#40;stream->type&#41; &#123;
    case STD_IOBUF_TYPE_GS&#58;
    case STD_IOBUF_TYPE_SIO&#58;
    case STD_IOBUF_TYPE_STDOUTHOST&#58;
      /* cannot read from stdout or stderr. */
      ret = EOF;
      break;
    default&#58;
      ret = &#40;&#40;fread&#40;&c, 1, 1, stream&#41; == 1&#41; ? &#40;int&#41;c &#58; EOF&#41;;
  &#125;
  return &#40;ret&#41;;
&#125;

"char c;" need to be replaced by "unsigned char c;", because casting to int will extend the sign. All negative values will be wrongly converted. Can someone change it in the svn repository?

Posted: **Mon Sep 18, 2006 7:59 pm**

I'll check that tonight.

-> same thing also for getc()

did you run the non regression test present in the ps2sdk ?

regards,
Evilo.

Posted: **Mon Sep 18, 2006 9:37 pm**

Following your remark, I also noticed that fputc could be wrong as well:

Code: Select all

int fputc&#40;int c, FILE *stream&#41;
&#123;
  char ch;

  ch = &#40;char&#41;c;
  return &#40;&#40;fwrite&#40;&ch, 1, 1, stream&#41; == 1&#41; ? 0 &#58; EOF&#41;;
&#125;
#endif

should better be :

Code: Select all

int fputc&#40;int c, FILE *stream&#41;
&#123;
  unsigned char ch = &#40;unsigned char&#41; c;

  return &#40;&#40;fwrite&#40;&ch, 1, 1, stream&#41; == 1&#41; ? 0 &#58; EOF&#41;;
&#125;
#endif

do you confirm ?

[EDIT] While reviewing stdio.c, I also noticed that EOF is never raised in case the number of byte read (in fread) is smaller that the number of bytes requested... I guess nobody had an issue with that until now :)

Posted: **Tue Sep 19, 2006 7:31 am**

evilo wrote: do you confirm ?

Yes, because the linux programmer's manual says:
fputc() writes the character c, cast to an unsigned char, to stream. I think it is a good idea to be compatible to linux.

I didn't know anything about the testsuite before. Did you mean the test program in "ee/libc/regress". I run it and it is working, only stat() is not implemented. I think it should be possible to implement stat() by using fioGetstat() or fileXioGetStat().

Posted: **Wed Sep 20, 2006 6:28 am**

I found the same error in ee/kernel/stdio.c

Code: Select all

#ifdef F_fio_getc
int fioGetc&#40;int fd&#41;
&#123;
	int c;

	fioRead&#40;fd,&c,1&#41;;
	return c;
&#125;
#endif

Else, back to stdio.c I also previously added a constant for the USB_MASS device

Code: Select all

#define STD_IOBUF_TYPE_MASS           64

Code: Select all

static struct &#123;
  char * prefix;
  int len;
  int ret;
&#125; __prefix_types&#91;&#93; = &#123;
    &#123; "cdrom0&#58;", 7, STD_IOBUF_TYPE_CDROM &#125;,
    &#123; "cdrom&#58;",  6, STD_IOBUF_TYPE_CDROM &#125;,
    &#123; "mc0&#58;",    4, STD_IOBUF_TYPE_MC &#125;,
    &#123; "mc1&#58;",    4, STD_IOBUF_TYPE_MC &#125;,
    &#123; "host0&#58;",  6, STD_IOBUF_TYPE_HOST &#125;,
    &#123; "host&#58;",   5, STD_IOBUF_TYPE_HOST &#125;,
    &#123; "mass0&#58;",  6, STD_IOBUF_TYPE_MASS &#125;,
    &#123; "mass&#58;",   5, STD_IOBUF_TYPE_MASS &#125;,
    &#123; 0, 0 &#125;
&#125;;

so __stdio_get_fd_type() doesn't return -1 for that device. I know that this is not really required (since it's working the same anyway), but i find it a little cleaner like this :)

and yes I know, I should use "patch" to specify my files diff, but you know, i'm lazy !

any remarks from a "ps2sdk guru" before I commit everything ?

Posted: **Mon Nov 27, 2006 2:04 am**

commited !

forums.ps2dev.org

fgetc() returns EOF before end of file.

fgetc() returns EOF before end of file.