[SOLVED] Recursive delete...

[ne0h]

Hi,
I've find this recursive function to delete a directory, but when I try to delete a big dir (PSP) , it was deleted all the MS!!
I've try to modify it but it's not perfect!
I think there are a basically solution, but I'haven't find it!
What's wrong in this function?
It's a possible bug of sceIoRmDir or sceIoDelete funct?

Code: Select all

void RmDir(char *dir)
{
 SceIoDirent dirent;
 int fd;
 char fullname[512];
 fd = sceIoDopen(dir);
 memset(&dirent, 0, sizeof dirent);
 while (sceIoDread(fd, &dirent) > 0)
 {
  sprintf(fullname, "%s/%s", dir, dirent.d_name);

   if ((FIO_S_IFREG & (dirent.d_stat.st_mode & FIO_S_IFMT)) == 0)
      {
             RmDir(fullname);
             sceIoRmdir(fullname);
         }
  else
      {
      sceIoRemove(fullname);
      }
  }
 sceIoDclose(fd);
 sceIoRmdir(dir);
}

I think the problem is in the string fullname and in it's allocate ( not perfect english I think)

[Insert_witty_name]

What you call a big dir?

A directory with lots of files in it, or a directory with a really long name?

[hlide]

Oh come on ! your wonderful function is not even slightly recursive. Is it so hard to think by yourself instead of gibbering ?

[ne0h]

This function is not my, I've searched and I've find this!
I call big dir a directory with a lot of dir and files

[ne0h]

This function is not my, I've searched and I've find this!
I call big dir a directory with a lot of dir and files
hilde, I haven't understand your post!
Explain your problem please!

[Insert_witty_name]

Hint: Your function is named RmDir().

Internally it's calling recursiveDelete()

Spot the difference.

That's what hlide meant by it not being recursive.

If you want to rename functions, ensure you rename all of them!

[ne0h]

Excuse me,
I've writed bad the fuct ( the old func is named recursivedelete, but in my prog i've changed the name to RmDir)
However thanks but this is not the error

[hlide]

Excuse me,
I've writed bad the fuct ( the old func is named recursivedelete, but in my prog i've changed the name to RmDir)
However thanks but this is not the error

if so, why to remove a directory twice ? kinda fishy your excuse...

Code: Select all

void RmDir(char *dir) 
{ 
 SceIoDirent dirent; 
 int fd; 
 char fullname[512]; 
 fd = sceIoDopen(dir); 
 memset(&dirent, 0, sizeof dirent); 
 while (sceIoDread(fd, &dirent) > 0) 
 { 
  sprintf(fullname, "%s/%s", dir, dirent.d_name); 

   if ((FIO_S_IFREG & (dirent.d_stat.st_mode & FIO_S_IFMT)) == 0) 
      { 
             RmDir(fullname); 
             >>>sceIoRmdir&#40;fullname&#41;;<<< 
         &#125; 
  else 
      &#123; 
      sceIoRemove&#40;fullname&#41;; 
      &#125; 
  &#125; 
 sceIoDclose&#40;fd&#41;; 
 >>>sceIoRmdir&#40;dir&#41;;<<< 
&#125; 

[ne0h]

yes, it's a error but this is not my problem

[J.F.]

You need to watch recursive functions - their greatest fault is the amount of stack space they consume. Look at ONE thing in the function:

Code: Select all

 char fullname[512]; 

Every recursion will consume that much stack space. If a dir has a thousand files, it will consume a thousand times the stack space. Make sure you have a BIG stack when using functions like this.

[ne0h]

Ok, this is not the error but I've try to resolve it yet:

Code: Select all

int Rmdir(char *dir)
{
    SceIoDirent dirent;
    int fd;
    fd = sceIoDopen(dir);
    memset(&dirent, 0, sizeof dirent);
    char *fullname=(char*)malloc(1);
    free(fullname);
    while (sceIoDread(fd, &dirent) > 0)
    {
        fullname=(char*)malloc(strlen(dir)+strlen(dirent.d_name)+1);
        sprintf(fullname, "%s/%s", dir, dirent.d_name);
        if ((FIO_S_IFREG & (dirent.d_stat.st_mode & FIO_S_IFMT)) == 0)
        {
             Rmdir(fullname);
             sceIoRmdir(fullname);
        }
        else
        {
             sceIoRemove(fullname);
        }
    }
    sceIoDclose(fd);
    sceIoRmdir(dir);
    return 0;
}

I've writed it speedly, I think is not perfect! ( For memory use )

[hlide]

RmDir("ms0:/blabla") will call :
>RmDir("ms0:/blabla/bloblo");
>>sceIoRmdir("ms0:/blabla/bloblo"); // just after sceIoDclose(fd);
>sceIoRmdir("ms0:/blabla/bloblo"); // just after RmDir(fullname);
>sceIoRmdir("ms0:/blabla"); // just after sceIoDclose(fd);

Now, who's the idiot ?

[ne0h]

What? Excuse me, maybe I'm a idiot but I haven't understand your post!

[hlide]

not a surprise

[ne0h]

hlide, if I want delete a folder named "FOLDER", I think if I don't write the final sceIoRmDir the dir will be not deleted
J.F., I think the memory it's not the problem, because if I try yet to delete a big directory the PSP crash!

[hlide]

well i guess C is not your forte

[ne0h]

bah

[Question_dev]

I know a site where you can find a del dir example.
http://www.pspcoding.co.nr

Goto Coding Examples -> C/C++ Examples

Hope this helps.
Cu

[ne0h]

But what's wrong in my function?
I want know the bug if is possible!

[ne0h]

Yeah, maybe I've resolved!

Code: Select all

int Rmdir(char *dir)
{
    SceIoDirent dirent;
    int fd;
    fd = sceIoDopen(dir);
    memset(&dirent, 0, sizeof dirent);
    char *fullname=(char*)malloc(1);
    free(fullname);
    while (sceIoDread(fd, &dirent) > 0)
    {
        fullname=(char*)malloc(strlen(dir)+strlen(dirent.d_name)+1);
        sprintf(fullname, "%s/%s", dir, dirent.d_name);
        if ((FIO_S_IFREG & (dirent.d_stat.st_mode & FIO_S_IFMT)) == 0)
        {
             Rmdir(fullname);
             sceIoRmdir(fullname);
        }
        else
        {
             sceIoRemove(fullname);
--------->memset(&dirent, 0, sizeof dirent);
        }
    }
    sceIoDclose(fd);
    sceIoRmdir(dir);
    return 0;
}

[Question_dev]

Compare the two.

If you can't find it by yourself, then you need to learn c.

Also, ever heard about google? "c delete dir"

Cu

[ne0h]

... I've already resolved!
I've posted before read the other example!
Thanks, Question_dev!

[hlide]

"I've already resolved! " is your motto ? it sounds quite repetive to my ears... and unnecessary to say

[ne0h]

I've writed this funct but this uses all the RAM!!!!
Why?

Code: Select all

int Rmdir(char *dir)
{
    SceIoDirent dirent;
    int fd;
    fd = sceIoDopen(dir);
    memset(&dirent, 0, sizeof dirent);
    while (sceIoDread(fd, &dirent) > 0)
    {
        char fullname[strlen(dir)+strlen(dirent.d_name)+1];
        sprintf(fullname, "%s/%s", dir, dirent.d_name);
        if ((FIO_S_IFREG & (dirent.d_stat.st_mode & FIO_S_IFMT)) == 0)
        {
             Rmdir(fullname);
             sceIoRmdir(fullname);
        }
        else
        {
             sceIoRemove(fullname);
             memset(&dirent, 0, sizeof dirent);
        }
    }
    sceIoDclose(fd);
    sceIoRmdir(dir);
    return 0;
}

[ne0h]

Thanks!...

[Pirata Nervo]

I lol'd at this thread.
@ne0h, make sure you learn some C coding before saying hlide is an idiot and does not know C and is more stupid than you. I believe hlide has a lot more C experience than you.
Also, it's not "I've writed", writed does not exists.
I'ts I've written or I wrote. (at least this is what I know from my english lol)

@Question Dev, maybe google will not be his best friend for coding lol and I think you are not the right person to say "SEARCH" as you were like him a few months ago.

Edit, don't bump your posts please. Wait for an answer if you even deserve one.

[ne0h]

bah...
I have understand what hlide intend to say yet...

[Pirata Nervo]

It's I haven't understood. (irregular verb)
he meant you were trying to delete the same directory after it was deleted.

Code: Select all

             RmDir(fullname);
             sceIoRmdir(fullname); 

you run your RmDir function to delete the folder then you run sony's function to delete the folder, again.

Do you understand?

[ne0h]

yes, yes, I have understand...

[Pirata Nervo]

ok, now how do you know your function is using all the ram?