what's the meaning of this code from stdlib.c

[ldqmoon]

Code: Select all

#ifdef F_div
/*
**
** [func] - div.
** [desc] -
** [entr] - int n; the integer numerator.
** int d; the integer divisor.
** [exit] - div_t;
** [prec] - none.
** [post] - none.
**
*/ div_t div(int n, int d)
{
div_t ret;

/* calculate the quotient and remainder. */ // duh... can't this be written with some asm "mfhi/mflo" ?
ret.quot = (n / d);
ret.quot = (n % d);
ret.rem = 0; // set to 0 so it won't be uninitialized
return (ret);
}
#endif

ret.quot = (n / d);
ret.quot = (n % d);

why it write like this ?

Thank you!

[jimparis]

it was a typo, and the "ret.rem = 0" line was a misguided attempt by ooPo to fix a compiler warning. i'll fix it now, although
- using psplibc isn't recommended
- does anyone actually use div()?

[ooPo]

Misguided attempt? Are you sure it was me? :)

[jimparis]

yes :)

Code: Select all

$ svn blame -r{20080727} stdlib.c | grep -A 10 "div_t div"
    23    tyranid div_t div(int n, int d)
    23    tyranid {
    23    tyranid   div_t ret;
    23    tyranid 
    23    tyranid   /* calculate the quotient and remainder. */
    23    tyranid   // duh... can't this be written with some asm "mfhi/mflo" ?
    23    tyranid   ret.quot = (n / d);
    23    tyranid   ret.quot = (n % d);
   176       oopo   ret.rem = 0; // set to 0 so it won't be uninitialized
    23    tyranid   return (ret);
    23    tyranid }

$ svn log -r176 stdlib.c
------------------------------------------------------------------------
r176 | oopo | 2005-06-14 15:08:24 -0400 (Tue, 14 Jun 2005) | 2 lines

Fixing various compiler warnings. There are very few compared to ps2sdk. :)

------------------------------------------------------------------------

[TyRaNiD]

I would like to point out that although my name is in that list of blame I just copied and pasted it from the ps2sdk, hehe :P

[ooPo]

Crap. Now I look like a noob.

NOOB SAIBOT YEAH!!! FATALITY!!!

[ooPo]

Fixed in ps2sdk now, too.